Issue1059 control io no socket #1170
Conversation
…NoSocket issue1059_controlIONoSocket
…NoSocket issue1059_controlIONoSocket - Removed energy signals
…NoSocket Updated signal types
…NoSocket Merge latest master.
|
FYI @JavierArroyoBastida, I've made this PR and asked for a review by @mwetter . |
There was a problem hiding this comment.
@dhblum : This is in my view fine to merge. I reviewed all code and documentation and made changes to the documentation where needed. I also added info for all package.mo files.
Note the change in 35ccf6e in which I changed the parameter name to lower case for consistency (instance names are typically lower case). This probably has side effects in downstream tools. I am not sure how disruptive this will be.
If you agree, please ask @PMehrfeld for a review so that we have a non-LBL and non-KU Leuven person reviewing it before it can be merged.
|
@mwetter Thank you for completing your review. I agree with all of your suggestions, except made one correction to revision documentation, which I've fixed in efd933f. The change in parameter name to lower case is noted. It will affect downstream tools, but should be fixed easily. I've already added it as a to-do in the BOTEST repo at ibpsa/project1-boptest#49. |
|
Thanks @dhblum . |
|
@PMehrfeld : can you please review and merge if you agree with the implementation. |
For #1059.