Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added phi=max(y_actual,0) for all two way valves #1242

Merged
merged 6 commits into from
Nov 13, 2019
Merged

added phi=max(y_actual,0) for all two way valves #1242

merged 6 commits into from
Nov 13, 2019

Conversation

Mathadon
Copy link
Member

@Mathadon Mathadon commented Nov 9, 2019

removed assert that checks phi > -0.2
closes #1223

@Mathadon
added phi=max(y_actual,0) for all two way valves
d49f1e4 
removed assert that checks phi > -0.2
see #1223
@Mathadon Mathadon removed their assignment Nov 10, 2019
@Mathadon
Copy link
Member Author

I have revised the implementation such that phi never becomes negative, instead of y_actual. This has the advantage that the bound is not active within the normal operating region of the valve.

@mwetter mwetter mentioned this pull request Nov 13, 2019
Merged
@mwetter mwetter merged commit d001140 into master Nov 13, 2019
@mwetter mwetter deleted the issue1223_minValveInput branch November 13, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter Awaiting requested review from mwetter

Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bound inputs of valves
2 participants
@Mathadon @mwetter