-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1188 dampers refactor #1267
Conversation
(e.g. SimpleHouse was not converted otherwise)
…the instance name
Note the addition of We should do this throughout the library. Otherwise, JModelica will not write which instance triggered the assertion. I updated the style guide at @AntoineGautier Can you please set the new default value for |
@Mathadon @PMehrfeld @nytschgeusen This is a non backward compatible PR waiting for your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineGautier: Thank you very much for your huge effort you put into these good changes! And thanks for the good issue documentation (especially the slides were helpful).
I approve, but please address my comments and implement the suggestions. Although none of them are truly critical or impact the results. But I think it raises the usability.
Additionally, I have this comment:
All three classes on top level of the Dampers
package need to parametrize the damper coefficients. But only Exponential
provides this very helpful table acc. to ASHRAE 825-RP.
I suggest to move this table to
a) the two other models as well or
b) the base class model PartialDamperExponential
.
If you are going with option b) you should highlight that the standard parameters are valid for opposed blades
.
Additionally, you should comment that k0
is now determined by the leakage parameter l
and others.
@PMehrfeld Thanks a lot for the detailed review. I addressed your comments in my last commits. |
@mwetter This is ready to merge. |
@AntoineGautier : I removed the assignments |
This PR only partially addresses #1188.
It deals with:
VAVBoxExponential
andExponential
,dp_nominalIncludesDamper
in favor ofdpDamper_nominal
anddpFixed_nominal
.The modification of
PressureIndependent
will be addressed in a next PR.Note:
dpDamper_nominal
~ 0.3 Pa (former default). It is pushed as is in order to illustrate the low impact of the refactoring on the reference results. However it might be ultimately better to present to the user more representative values (10 Pa) in the examples.k0
in favor of the leakage coefficient is not handled by the conversion script (I made the assumption that no user would have modified the default value for that parameter).Actuators.Dampers.VAVBoxExponential vavDam(...)
inIBPSA.Fluid.Examples.SimpleHouse
is not converted by simply usingIBPSA.Actuators.Dampers.VAVBoxExponential
in the conversion script.