Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1376 valve leakage #1383

Merged
merged 5 commits into from Aug 7, 2020
Merged

Issue1376 valve leakage #1383

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2daad0
Merge pull request #1 from ibpsa/master
EttoreZ Mar 17, 2020
76e5d94
Merge pull request #3 from ibpsa/master
EttoreZ Apr 7, 2020
a66fa5c
Merge pull request #13 from ibpsa/master
EttoreZ Aug 4, 2020
4eed13f
update twowayvalves phi calculation by changing 0 to 0.1*l
Aug 4, 2020
295d91b
Updated reference to change for two way valves phi calculation
Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayEqualPercentage.mo
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ within IBPSA.Fluid.Actuators.Valves;
model TwoWayEqualPercentage
"Two way valve with equal percentage flow characteristics"
extends BaseClasses.PartialTwoWayValveKv(
phi=max(0, if homotopyInitialization then
phi=max(0.1*l, if homotopyInitialization then
homotopy(actual=IBPSA.Fluid.Actuators.BaseClasses.equalPercentage(
y_actual,
R,
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayLinear.mo
View file
Open in desktop
@@ -1,6 +1,6 @@
within IBPSA.Fluid.Actuators.Valves;
model TwoWayLinear "Two way valve with linear flow characteristics"
extends BaseClasses.PartialTwoWayValveKv(phi=max(0, l + y_actual*(1 - l)));
extends BaseClasses.PartialTwoWayValveKv(phi=max(0.1*l, l + y_actual*(1 - l)));

initial equation
// Since the flow model IBPSA.Fluid.BaseClasses.FlowModels.basicFlowFunction_m_flow computes
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayPolynomial.mo
View file
Open in desktop
@@ -1,7 +1,7 @@
within IBPSA.Fluid.Actuators.Valves;
model TwoWayPolynomial "Two way valve with polynomial characteristic"
extends IBPSA.Fluid.Actuators.BaseClasses.PartialTwoWayValveKv(
phi=max(0, l + pol_y*(1 - l)));
phi=max(0.1*l, l + pol_y*(1 - l)));

parameter Real[:] c
"Polynomial coefficients, starting with fixed offset";
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayPressureIndependent.mo
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ model TwoWayPressureIndependent "Model of a pressure-independent two way valve"
extends IBPSA.Fluid.Actuators.BaseClasses.PartialTwoWayValve(
final linearized = false,
from_dp=true,
phi=max(0, l + y_actual*(1 - l)));
phi=max(0.1*l, l + y_actual*(1 - l)));

parameter Real l2(min=1e-10) = 0.01
"Gain for mass flow increase if pressure is above nominal pressure"
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayQuickOpening.mo
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@ within IBPSA.Fluid.Actuators.Valves;
model TwoWayQuickOpening
"Two way valve with quick opening flow characteristics"
extends BaseClasses.PartialTwoWayValveKv(
phi=max(0,
phi=max(0.1*l,
if homotopyInitialization then
homotopy(
actual=l + Modelica.Fluid.Utilities.regPow(
Expand Down
2 changes: 1 addition & 1 deletion IBPSA/Fluid/Actuators/Valves/TwoWayTable.mo
View file
Open in desktop
@@ -1,7 +1,7 @@
within IBPSA.Fluid.Actuators.Valves;
model TwoWayTable "Two way valve with table-specified flow characteristics"
extends BaseClasses.PartialTwoWayValveKv(
phi=max(0, phiLooUp.y[1]),
phi=max(0.1*l, phiLooUp.y[1]),
final l = phiLooUp.table[1, 2]);
parameter Data.Generic flowCharacteristics "Table with flow characteristics"
annotation (choicesAllMatching=true, Placement(transformation(extent={{-80,
Expand Down