Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed example to avoid redundant initial conditions #1834

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Changed example to avoid redundant initial conditions #1834

merged 3 commits into from
Feb 7, 2024

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 1, 2024

This closes #1830

@mwetter mwetter mentioned this pull request Feb 1, 2024
Closed
@mwetter mwetter marked this pull request as ready for review February 5, 2024 14:03
AntoineGautier
AntoineGautier approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@AntoineGautier AntoineGautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwetter The change looks good to me. On top of it, in bb1ed02 I added the annotation Evaluate=true to avoid the following warning in Dymola.

Pedantic translation of IBPSA.Fluid.Sensors.Examples.PPM
 Non-literal value.
In nominal attribute for dp.m_flow.

@mwetter
Copy link
Contributor Author

mwetter commented Feb 7, 2024

@AntoineGautier : Thanks for adding the annotation.

@mwetter mwetter merged commit 14b370d into master Feb 7, 2024
3 checks passed
@mwetter mwetter deleted the issue1830_redundantInitialConditions branch February 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineGautier AntoineGautier AntoineGautier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structurally singular initial equation system in PPM model
2 participants
@mwetter @AntoineGautier