Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Image #1

Closed
winstonma opened this issue Jan 6, 2020 · 3 comments
Closed

Responsive Image #1

winstonma opened this issue Jan 6, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@winstonma
Copy link

winstonma commented Jan 6, 2020

Currently the package loads the hqdefault image.

I am using your package and bootstrap to display the youtube on a website. Therefore it would be great if the choice of image could be based on the width of the frame (e.g. load mqdefault on mobile and maxresdefault on desktop).

EDIT: I just saw it is configurable. Just wonder if it is possible that it is automatic.

@ibrahimcesar ibrahimcesar added the enhancement New feature or request label Jan 23, 2020
@ibrahimcesar
Copy link
Owner

Great idea! I'll work on this for a next release.

Thanks!

@ibrahimcesar ibrahimcesar self-assigned this Jan 23, 2020
@winstonma
Copy link
Author

winstonma commented Feb 7, 2020

I would like to add some comment here.

I used to use the lazyYT and it would load the image accordingly. It is determined in the loadBackgroundImage function inside lazyYT.js.

@ibrahimcesar
Copy link
Owner

Thanks @winstonma , I'll take a look!

ibrahimcesar pushed a commit that referenced this issue Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants