Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LiteYouTube interface export #76

Closed
alex-loktiev opened this issue Sep 28, 2022 · 1 comment · Fixed by #82
Closed

The LiteYouTube interface export #76

alex-loktiev opened this issue Sep 28, 2022 · 1 comment · Fixed by #82
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alex-loktiev
Copy link

alex-loktiev commented Sep 28, 2022

Description
It is a bit limited to use this awesome library with Typescript, because the LiteYouTube interface is not exported, there is no possibility to import it, and all the props should be defined in the end consuming app. That can lead to the situation when the defined in the end application interface is not up to date with the LiteYouTube one. It would be great to have an opportunity to import it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the consuming app, that is based on the Typescript
  2. Try to import the LiteYouTube interface

Expected behavior
You can import the interface

Desktop :

  • Browser [e.g. chrome, safari]

Screenshot 2022-09-28 at 12 09 23

@ibrahimcesar ibrahimcesar self-assigned this Nov 3, 2022
@ibrahimcesar ibrahimcesar added the bug Something isn't working label Nov 3, 2022
@ibrahimcesar ibrahimcesar pinned this issue Nov 3, 2022
@ibrahimcesar ibrahimcesar added the good first issue Good for newcomers label Nov 3, 2022
ibrahimcesar added a commit that referenced this issue Nov 3, 2022
@ibrahimcesar
Copy link
Owner

Thanks! Realeased!

@ibrahimcesar ibrahimcesar linked a pull request Nov 3, 2022 that will close this issue
ibrahimcesar added a commit that referenced this issue Nov 3, 2022
@ibrahimcesar ibrahimcesar unpinned this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants