Refactoring and CI workflow maintenance

ibrahimgunduz34 · Apr 25, 2022 · 2f29caa · 2f29caa
1 parent d7cf86d
commit 2f29caa
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 16 deletions.
diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
@@ -7,11 +7,14 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [ '12', '14', '16' ]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: ${{ matrix.node }}
       - name: Install Dependencies
         run: npm install
       - name: Check code style

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -3,16 +3,20 @@
 
 name: Pull Request Workflow
 
-on: pull_request
+on: [pull_request, push]
 
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [ '12', '14', '16' ]
+    name: Build For Node ${{ matrix.node }} 
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: ${{ matrix.node }}
       - name: Install Dependencies
         run: npm install
       - name: Check code style

diff --git a/package.json b/package.json
@@ -1,13 +1,22 @@
 {
   "name": "@ibrahimgunduz34/process-list",
-  "version": "1.0.12",
+  "version": "1.0.13",
   "description": "It's a library that simply wrap the ps command in order to access the active process list from your application.",
   "main": "src/process-list.js",
   "scripts": {
     "test": "mocha",
     "lint": "eslint -c .eslintrc.json ."
   },
-  "keywords": [],
+  "keywords": [
+    "system information",
+    "monitoring",
+    "backend",
+    "os",
+    "linux",
+    "osx",
+    "windows",
+    "freebsd"
+  ],
   "author": "Ibrahim Gunduz <ibrahimgunduz34@gmail.com>",
   "license": "ISC",
   "devDependencies": {

diff --git a/tests/process-list.spec.js b/tests/process-list.spec.js
@@ -51,9 +51,7 @@ describe('ProcessList Tests', () => {
           );
 
           ProcessList.getList()
-            .then(() => {
-              done('It was expected that getList throws an error');
-            })
+            .then(() => done('It was expected that getList throws an error'))
             .catch((error) => {
               // Chai fails when the error and expected error was compared with `deep.equal`
               expect(error).to.include(expectedError);
@@ -88,10 +86,8 @@ describe('ProcessList Tests', () => {
       describe(scenario.scenario, () => {
         it(scenario.expectation, (done) => {
           ProcessList.getList({ asArray: scenario.asArray })
-            .then((processes) => {
-              expect(processes).to.be.deep.equal(scenario.expectedResult);
-              done();
-            })
+            .then((processes) => expect(processes).to.be.deep.equal(scenario.expectedResult))
+            .then(() => done())
             .catch(done);
 
           const output = commandOutputGenerator.createSuccessfulPsOutput();
@@ -107,10 +103,8 @@ describe('ProcessList Tests', () => {
         const expectedResult = expectedResultGenerator.createGetListResultAsObject();
 
         ProcessList.getList()
-          .then((processes) => {
-            expect(processes).to.be.deep.equal(expectedResult);
-            done();
-          })
+          .then((processes) => expect(processes).to.be.deep.equal(expectedResult))
+          .then(() => done())
           .catch(done);
 
         const output = commandOutputGenerator.createSuccessfulPsOutput();