Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cast from reference to pointer #45

Merged
merged 1 commit into from
Aug 27, 2014

Conversation

SebastianSchildt
Copy link

OS X/clang build failed with

Logger.cpp:169:8: error: cannot cast from type 'std::ostream' (aka 'basic_ostream') to pointer type 'void '
if ((void
)stream == (void_)output.stream)
^~~~~~~~~~~~~
Logger.cpp:169:25: error: cannot cast from type 'std::ostream' (aka 'basic_ostream') to pointer type 'void *'
if ((void
)stream == (void*)output._stream)
^~~~~~~~~~~~~~~~~~~~~

because stream and LoggerOutput._stream are references. Need an & operator before casting

@morgenroth
Copy link

Please prefix all commits dedicated to the ibrcommon library with the key-word: "ibrcommon".
E.g. instead of "Missing cast from reference to pointer" set "ibrcommon: Missing cast from reference to pointer" as commit title.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f77a864 on SebastianSchildt:osxcompilefix into 89a8285 on ibrdtn:master.

morgenroth added a commit that referenced this pull request Aug 27, 2014
ibrcommon: Missing cast from reference to pointer
@morgenroth morgenroth merged commit da0238c into ibrdtn:master Aug 27, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 3029811 on SebastianSchildt:osxcompilefix into 89a8285 on ibrdtn:master.

@SebastianSchildt SebastianSchildt deleted the osxcompilefix branch August 27, 2014 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants