Missing cast from reference to pointer #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X/clang build failed with
Logger.cpp:169:8: error: cannot cast from type 'std::ostream' (aka 'basic_ostream') to pointer type 'void '
if ((void)stream == (void_)output.stream)
^~~~~~~~~~~~~
Logger.cpp:169:25: error: cannot cast from type 'std::ostream' (aka 'basic_ostream') to pointer type 'void *'
if ((void)stream == (void*)output._stream)
^~~~~~~~~~~~~~~~~~~~~
because stream and LoggerOutput._stream are references. Need an & operator before casting