Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved to pyproject + development workflow + type checking #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Moved to pyproject + development workflow + type checking #18

wants to merge 6 commits into from

Conversation

lpawluczuk
Copy link
Collaborator

@lpawluczuk lpawluczuk commented Jun 2, 2023 •
edited

This PR contains three changes:

  • transition from setup.py to pyproject.toml
    • the goal is to have single configuration script instead of few (which includes requirements, linter configuration, testing configuration and additional things in future)
  • development workflow - each time Pull Request is created/updated it will automatically trigger linter and testing to make sure we didn't break anything with our changes
  • added type checking to everything apart from animations

@lpawluczuk lpawluczuk requested a review from mkjiskrz June 2, 2023 09:33
@lpawluczuk lpawluczuk changed the title Moved to pyproject + development workflow Moved to pyproject + development workflow + type checking Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkjiskrz mkjiskrz Awaiting requested review from mkjiskrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lpawluczuk