New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sqlite 3.41.0 build failed #12
Conversation
b667324
to
c616333
Compare
Could you format the commit message within 80 columns? |
c616333
to
4a967d9
Compare
Reformatted. |
I think it is also okay to remove the compile error from the commit message. Otherwise this patch looks good to me. |
Ok, I also think it can be removed, gentoo bugs provides all the error messages. |
4a967d9
to
ae59d68
Compare
Sorry, I missed one thing. How do you think to use |
I think I also miss that, float don't need quote here. |
As sqlite 3.41.0 release note say: The double-quoted string misfeature is now disabled by default for CLI builds. Legacy use cases can reenable the misfeature at run-time using the ".dbconfig dqs_dml on" and ".dbconfig dqs_ddl on" commands. We should change this double quote to single quote Ref: https://bugs.gentoo.org/896366 Signed-off-by: jinqiang zhang <peeweep@0x0.ee>
ae59d68
to
5634d3f
Compare
Thanks for review! |
Thanks for the patch! |
# Insert data into english table
- { printf "INSERT INTO english (word, freq) VALUES (\"%s\", \"%f\");\n", $1, $2}
+ { printf "INSERT INTO english (word, freq) VALUES (\'%s\', %f);\n", $1, $2} @peeweep @epico I found the extra backslash in this pull request to be problematic. When being executed by
When processed with I believe these backslashes are unnecessary and harmful. Could we drop them? After removing the backslashes, the build will success with either
|
@hosiet Okay, fixed. Thanks! |
data/db/english/english.awk run failed with sqlite 3.41.0, the error
message is:
As sqlite 3.41.0 release note say:
The double-quoted string misfeature is now disabled by default for CLI builds. Legacy use cases can reenable the misfeature at run-time using the ".dbconfig dqs_dml on" and ".dbconfig dqs_ddl on" commands.
We should change this double quote to single quote
Ref: https://bugs.gentoo.org/896366