Fix preference dialog breaking issue #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin: https://bugs.gentoo.org/905906
Problem
When trying to open the preference for
Chinese-Pinyin
inibus-setup
, an error is thrown:Cause
The relevant APIs were already removed in Python 3.10:
https://bugs.python.org/issue40936
https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset
This is a UX issue but does prevent basic functionalities.
Using python >=3.10 will raise this problem.
Potential Fix
By removing this single line seems to fix the issue. The preference can now function properly
No further usages of removed API were found.
Disclaimer
I haven't performed deeper testing to see if the removal of this line will cause problem elsewhere