Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid input engine respond to the Superkey #15

Merged
merged 1 commit into from Mar 20, 2024
Merged

Conversation

qiangzhao
Copy link

Avoid the input engine responding to the Superkey, otherwise, this will cause ibus-pinyin to not switch to other input engines under Wayland.

@qiangzhao
Copy link
Author

Hi maintainers: @phuang
With full respect. the "super + space" key binding stop works after using the ibus-pinyin to input Chinese. Env is openSUSE with Wayland. Xwindows don't have this issue.
Thank you so much for taking your valuable time to take a review!

@epico
Copy link
Member

epico commented Mar 15, 2024

Could you check whether the code in BopomofoEngine and PinyinEngine is necessary?

@epico epico changed the title Avoid input engine respond to the Superkey, Avoid input engine respond to the Superkey Mar 15, 2024
@qiangzhao
Copy link
Author

qiangzhao commented Mar 15, 2024

Could you check whether the code in BopomofoEngine and PinyinEngine is necessary?

Yes, you are right. I have test and update the request.
Thank you very much.

This will fix ibus-pinyin could not switch to
other engines after input Chinese under wayland.
@epico
Copy link
Member

epico commented Mar 20, 2024

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants