Add JWT secret to template files #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
commented
Dec 10, 2021
| @@ -91,6 +91,11 @@ objects: | |||
| secretKeyRef: | |||
| key: name | |||
| name: ibutsu-superadmin | |||
| - name: JWT_SECRET | |||
There was a problem hiding this comment.
@bsquizz what do we need to do on the AppSRE side? Add it to vault?
There was a problem hiding this comment.
Yep, we will add it to vault and then update the app-interface config for our namespace to insert the secret into the ns.
rsnyman
approved these changes
Jan 4, 2022
rsnyman
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #252