Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resolving timezones that was impacting performance when parsing… #406

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

benfortuna
Copy link
Member

… large calendar files

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #406 into develop will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #406      +/-   ##
=============================================
- Coverage      68.10%   68.09%   -0.02%     
+ Complexity      2036     2029       -7     
=============================================
  Files            313      313              
  Lines           8694     8684      -10     
  Branches        1258     1251       -7     
=============================================
- Hits            5921     5913       -8     
  Misses          2342     2342              
+ Partials         431      429       -2     
Impacted Files Coverage Δ Complexity Δ
...net/fortuna/ical4j/data/DefaultContentHandler.java 89.15% <90.47%> (+2.98%) 26.00 <9.00> (-6.00) ⬆️
...java/net/fortuna/ical4j/model/PropertyBuilder.java 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
.../java/net/fortuna/ical4j/model/property/RRule.java 72.00% <100.00%> (+1.16%) 7.00 <1.00> (ø)
...va/net/fortuna/ical4j/model/CalendarException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...rc/main/java/net/fortuna/ical4j/model/WeekDay.java 81.81% <0.00%> (-1.02%) 39.00% <0.00%> (-1.00%)
...et/fortuna/ical4j/validate/ParameterValidator.java 70.00% <0.00%> (+10.00%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed75510...9e26c33. Read the comment docs.

@benfortuna benfortuna merged commit ee1f505 into develop Mar 26, 2020
@benfortuna benfortuna deleted the bugfix/resolve-timezones branch March 26, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant