-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RFC7986 properties to calendar component #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @espen. In addition to the changes that I mention in-line, I'd really like us to support the recommendations in section 3 about outputting the VALUE
attribute to maintain backwards-compatibility. A test or two demonstrating compliance would be very much appreciated as well.
@@ -5,6 +5,17 @@ class Calendar < Component | |||
required_property :prodid | |||
optional_single_property :calscale | |||
optional_single_property :ip_method | |||
optional_single_property :ip_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several of these properties can actually be defined more than once, so they should use the optional_property
method instead of optional_single_property
On the calendar component, they are name
, description
, categories
, and image
optional_single_property :ip_name | |
optional_property :ip_name |
optional_single_property :source, Icalendar::Values::Uri | ||
optional_single_property :color | ||
optional_single_property :image, Icalendar::Values::Uri | ||
optional_single_property :conference, Icalendar::Values::Uri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conference
property was not added to the Calendar component, but should instead be added to the Event and Todo components (where they should use the optional_property
method). Several of the other properties should also be added to additional components in addition to the Calendar.
To be more clear, the tests I am interested in are around compliance with section 3. I don't think we need them for just adding the new properties. Also, if you think that part is too large for you to be able to get to, or over your head, just let me know and I can take a look at either offering suggestions or take over implementing it. |
This wouldn't have caused any troubles, it's a pity it wasn't merged. much like:
same for parsing, everything that is unknown could end up in that hash. This will make the library more robust to changes. |
No description provided.