add attr_accessor for 'until' in RRule #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Greg, I like the purpose of this pull request, but I've opened a new issue to track an implementation that will scale better with the future of this project. I'll work on it soon unless you want to take a shot at implementing it. Thanks, |
|
Ok, cool--I'll have a look at #27 and see if I can add anything useful there. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to access the 'until' variable for a project that uses icalendar, so rather than hacking my local gem, I figured it'd be worth it to submit a PR for the change. Apologies if I'm missing why the attribute shouldn't be accessible (or if there's anything wrong with the request). Thanks!
Greg