#245: Added a better analyzer pr job #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Document this please |
HannesVDB
reviewed
Apr 7, 2022
fastlane/Fastfile
Outdated
| @@ -44,6 +44,12 @@ lane :pr do | |||
| installFvmVersion | |||
|
|
|||
| Dir.chdir ".." do | |||
| ## The analysis_options_all_files is used to check that all files can compile. even the once ignored in the original analysis_options.yaml | |||
| ## We first check for full compilation. After that we check the rules of the original analysis_options.yaml | |||
| sh("mv", "analysis_options.yaml", "fastlane/analysis_options_original.yaml") | |||
There was a problem hiding this comment.
Would have used separate methods to do the full analysis and the default analysis.
This makes your code a bit more readable without the need of comments.
ikbendewilliam
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #245