Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/getx navigation test #266

Merged
merged 56 commits into from
Oct 14, 2022
Merged

Conversation

jorre127
Copy link
Contributor

@jorre127 jorre127 commented Oct 4, 2022

Implementation of Getx navigation + updates to locale_gen to remove need of context.

Copy link
Contributor

@vanlooverenkoen vanlooverenkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check all unawaited in tests

.vscode/settings.json Show resolved Hide resolved
lib/app.dart Outdated Show resolved Hide resolved
lib/app.dart Outdated Show resolved Hide resolved
lib/app.dart Outdated Show resolved Hide resolved
lib/model/exceptions/bad_request_error.dart Outdated Show resolved Hide resolved
lib/viewmodel/splash/splash_viewmodel.dart Outdated Show resolved Hide resolved
lib/viewmodel/splash/splash_viewmodel.dart Outdated Show resolved Hide resolved
lib/viewmodel/todo/todo_add/todo_add_viewmodel.dart Outdated Show resolved Hide resolved
test/navigator/main_navigator_splash_test.dart Outdated Show resolved Hide resolved
lib/model/exceptions/bad_request_error.dart Outdated Show resolved Hide resolved
lib/navigator/middle_ware/login_guard.dart Outdated Show resolved Hide resolved
lib/screen/todo/todo_list/todo_list_screen.dart Outdated Show resolved Hide resolved
lib/viewmodel/debug/debug_viewmodel.dart Outdated Show resolved Hide resolved
Base automatically changed from feature/flutter-upgrade-3-3-1 to master October 12, 2022 07:42
@vanlooverenkoen vanlooverenkoen changed the base branch from master to develop October 12, 2022 09:54
@Spaff
Copy link

Spaff commented Oct 12, 2022

misschien geen slecht idee om de license generator ook nog eens te runnen? voor de rest geen additional remarks 👍

@Spaff
Copy link

Spaff commented Oct 12, 2022

misschien geen slecht idee om de license generator ook nog eens te runnen? voor de rest geen additional remarks 👍

Deze moogde voorlopig negeren, op te pakken in
#252

lib/architecture.dart Show resolved Hide resolved
lib/database/flutter_template_database.dart Show resolved Hide resolved
lib/main_common.dart Show resolved Hide resolved
lib/model/snackbar/snackbar_data.dart Show resolved Hide resolved
lib/navigator/middle_ware/init_middle_ware.dart Outdated Show resolved Hide resolved
lib/screen/debug/debug_platform_selector_screen.dart Outdated Show resolved Hide resolved
lib/screen/debug/debug_screen.dart Show resolved Hide resolved
lib/util/extension/localization_extension.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@vanlooverenkoen vanlooverenkoen merged commit aa88d27 into develop Oct 14, 2022
@vanlooverenkoen vanlooverenkoen deleted the feature/getx-navigation-test branch October 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants