Merge pull request #4 from icapps/develop

Merge 'develop' into 'master'
icapps · Mar 19, 2018 · e6078a4 · e6078a4
2 parents 4935a9e + 74d5f1b
commit e6078a4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tree-house-errors",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "NodeJS default error definitions with an error parser utility function",
   "main": "build/index.js",
   "types": "build/index.d.ts",

diff --git a/src/lib/errorParser.ts b/src/lib/errorParser.ts
@@ -20,10 +20,11 @@ export function parseErrors(error: any) {
 
   // Return object easy to use for serialisation
   return {
+    id: parsedError.id,
     status: parsedError.status,
     code: parsedError.code,
     title: parsedError.message,
     detail: parsedError.detail || parsedError.message,
-    stack: error instanceof Error ? parsedError.stack : undefined, // At least add stacktrace for unknown errors
+    meta: error instanceof Error ? { stack: parsedError.stack } : undefined, // At least add stacktrace for unknown errors
   };
 }
diff --git a/tests/errorParser.test.ts b/tests/errorParser.test.ts
@@ -10,11 +10,12 @@ describe('errorParser', () => {
     it('Should return the default error when unknown object is passed', () => {
       const parsedError = parseErrors({ myProp: 'iDunno' });
       expect(parsedError).toMatchObject({
+        id: expect.any(String),
         status: defaultError.status,
         code: defaultError.code,
         title: defaultError.message,
         detail: defaultError.message,
-        stack: undefined,
+        meta: undefined,
       });
     });
 
@@ -31,6 +32,7 @@ describe('errorParser', () => {
     const expressValidationError = new ValidationError([{ name: 'myField' }], options);
     const parsedError = parseErrors(expressValidationError);
     expect(parsedError).toMatchObject({
+      id: expect.any(String),
       status: httpStatus.BAD_REQUEST,
       code: errors.INVALID_INPUT.code,
       title: errors.INVALID_INPUT.message,
@@ -45,6 +47,7 @@ describe('errorParser', () => {
       } catch (err) {
         const parsedError = parseErrors(err);
         expect(parsedError).toMatchObject({
+          id: expect.any(String),
           status: httpStatus.BAD_REQUEST,
           code: errors.INVALID_INPUT.code,
           title: errors.INVALID_INPUT.message,