Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DQD Emitter batch_size description (#336)
## Description <!-- Provide a brief description of the PR's purpose here. --> We originally had batch_size for DQD emitter include the solution returned by ask_dqd, i.e., if you want ask to return 36 solutions you need to put batch_size=37. We reverted this decision and now assume that ask_dqd only returns one solution, i.e., you will put batch_size=36 for the above example. This make the batch_size description between DQD and non-DQD emitters consistent. However, at some point we must have forgot to change the docstrings according. This PR address that. **Furthermore, I find that some configuration in sphere.py is not consistent with the original paper.** For example, the [CMA-MAE paper](https://arxiv.org/pdf/2205.10752.pdf) "select[s] a batch size $\lambda = 36$ following prior work" (Appendix A), while [this line](https://github.com/icaros-usc/pyribs/blob/7099f1ab7679d557f41a9608b9cdaaf075d30981/examples/sphere.py#L490C1-L490C26) clearly uses $\lambda=37$. Similarly, our sphere experiment with CMA-MAEGA also uses $\lambda=37$. I could be missing something here, so I figured I should try to clarify in this PR in case other users have same confusion as me. ## TODO <!-- Notable points that this PR has either accomplished or will accomplish. --> ## Questions <!-- Any concerns or points of confusion? --> ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [ ] ~I have added a one-line description of my change to the changelog in `HISTORY.md`~ - [x] This PR is ready to go
- Loading branch information