-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sigma
, sigma0
to gaussian_emitter
and iso_line_emitter
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btjanaka
requested changes
Jun 2, 2022
btjanaka
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. Have some comments I will talk to you about offline.
Visualizing using the new
GaussianEmitter (
|
itsdawei
commented
Jun 2, 2022
itsdawei
commented
Jun 2, 2022
itsdawei
commented
Jun 2, 2022
itsdawei
commented
Jun 2, 2022
btjanaka
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to configure different standard deviations (
sigma
,sigma0
) for initialization and sampling steps ofgaussian_emitter
andiso_line_emitter
.TODO / DONE
sigma0
to optional parameter (defaults tosigma
).sigma0
is used to generate new solutions when the archive is empty, and added parametersigma
, which used to sample solutions from a non-empty archive.sigma0
toIso_Line_Emitter
.iso_line_emitter_test::test_properties_are_correct
to test for sigma0.factory_test
to reflect constructor changeiso_line_emitter_test::test_sigma0_is_correct
andgaussian_emitter_test::test_sigma0_is_correct
Status
yapf
pytest
pylint
HISTORY.md
.