Implement batch addition in SlidingBoundariesArchive #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note on benchmarking: The benchmarks for this PR show a mean of 1.1s for the The speedup is likely due to the use of batch addition during the remapping phase. |
itsdawei
approved these changes
Oct 20, 2022
This reverts commit 3eb3ee1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we implemented batch addition in #221, we skipped SlidingBoundariesArchive since it was complicated. This PR fixes that.
TODO
Questions
Status
yapfpytestpylintHISTORY.md