New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement batch addition in archives #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btjanaka
changed the title
Implement add_batch method for archives
Implement batch insertion in archives
Jul 6, 2022
btjanaka
changed the title
Implement batch insertion in archives
Implement batch addition in archives
Jul 6, 2022
This reverts commit 4f28541.
btjanaka
commented
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review
This was referenced Jul 22, 2022
Merged
itsdawei
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
6 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The add() method will add solutions to the archive as a batch, which should greatly increase the archive speed.
add_single() is now the corresponding method which adds just one solution to the archive.
We obtained roughly 2x speedup on the sphere example --
python sphere.py cma_me_imp_mu
andpython sphere.py cma_me_imp
took 60-65s (compare with 140s in #220 (comment)). Note that this is all without numba, i.e. batched operations without numba are faster than single operations with numba.TODO
Rename add() and add_batch() to insert() and insert_single() for consistency with the rest of the API, e.g. index_of() and index_of_single()No point since we would have to changeAddStatus
, and we will check array shapes anywayFix add() in SlidingBoundariesArchive-> followup PRQuestions
Status
yapf
pytest
pylint
HISTORY.md
.