Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS Session not closed if an exception is thrown #85

Closed
RKrahl opened this issue May 18, 2018 · 1 comment · Fixed by #86 or #91
Closed

JMS Session not closed if an exception is thrown #85

RKrahl opened this issue May 18, 2018 · 1 comment · Fixed by #86 or #91
Assignees
@RKrahl
Labels
bug Something isn't working
Milestone
1.9.1

Comments

@RKrahl
Copy link
Member

RKrahl commented May 18, 2018

See icatproject/icat.server#202.
@RKrahl RKrahl added the bug Something isn't working label May 18, 2018
RKrahl added a commit that referenced this issue May 18, 2018
@RKrahl
Create Session and MessageProducer in Transmitter.init(). Fixes #85.
6f95ac3
@RKrahl RKrahl mentioned this issue May 18, 2018
Merged
@RKrahl RKrahl added this to the 1.9.0 milestone May 18, 2018
@RKrahl
Copy link
Member Author

RKrahl commented Nov 20, 2018

It seems that the fix from #86 introduced another issue: the Session and the MessageProducer created in init() may not be concurrently accessed from multiple threads. We must revert this fix.

@RKrahl RKrahl reopened this Nov 20, 2018
@RKrahl RKrahl modified the milestones: 1.9.0, 1.10.0, 1.9.1 Nov 20, 2018
RKrahl added a commit that referenced this issue Nov 20, 2018
@RKrahl
Create the JMS Session in a try-with-resources statement. Fix #85.
2facedf
@RKrahl RKrahl mentioned this issue Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RKrahl RKrahl

Labels
bug Something isn't working
Projects
None yet
Milestone
1.9.1
2 participants
@fisherab @RKrahl