Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to link datasets with samples in icat.ingest #125

Closed
RKrahl opened this issue Jun 26, 2023 · 0 comments · Fixed by #140
Closed

Add support to link datasets with samples in icat.ingest #125

RKrahl opened this issue Jun 26, 2023 · 0 comments · Fixed by #140
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@RKrahl
Copy link
Member

RKrahl commented Jun 26, 2023

The icat.ingest as it will be implemented in #123 will not support to link the datasets ingested by the IngestReader with samples. Obviously, this should be supported.

But to do that right, we would need #122 in the implementation and that is why this will be postponed to 1.2.0.
@RKrahl RKrahl added enhancement New feature or request blocked Another issue needs to solved before working on this one labels Jun 26, 2023
@RKrahl RKrahl added this to the 1.2.0 milestone Jun 26, 2023
@RKrahl RKrahl removed the blocked Another issue needs to solved before working on this one label Oct 17, 2023
RKrahl added a commit that referenced this issue Oct 20, 2023
@RKrahl
Add a test for Issue #125
1c9cbf7
@RKrahl RKrahl mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Add support to link datasets with samples in icat.ingest icatproject/python-icat
1 participant
@RKrahl