Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDSClient.getApiVersion() will yield wrong result when the call is removed from ids.server #131

Closed
RKrahl opened this issue Aug 11, 2023 · 0 comments · Fixed by #135
Closed

IDSClient.getApiVersion() will yield wrong result when the call is removed from ids.server #131

RKrahl opened this issue Aug 11, 2023 · 0 comments · Fixed by #135
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@RKrahl
Copy link
Member

RKrahl commented Aug 11, 2023 •
edited

The getApiVersion call in ids.server has been added in 1.3.0, was deprecated in 1.8.0 and will be removed in 2.0.0.

The class IDSClient in python-icat provides a method by the same name getApiVersion() that implements this API call in the client. Even though the deprecation in ids.server is known since quite some time, the client method is not prepared for the upcoming removal. It will yield the wrong version number 1.2.0 for ids.server 2.0.0 and newer.
@RKrahl RKrahl added the bug Something isn't working label Aug 11, 2023
@RKrahl RKrahl added this to the 1.2.0 milestone Aug 11, 2023
RKrahl added a commit that referenced this issue Oct 18, 2023
@RKrahl
Add a test for Issue #131
dc8cd20
@RKrahl RKrahl mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix IDSClient.getApiVersion() icatproject/python-icat
1 participant
@RKrahl