Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSelection should also accept DataCollection as argument #74

Closed
RKrahl opened this issue May 15, 2020 · 0 comments
Closed

DataSelection should also accept DataCollection as argument #74

RKrahl opened this issue May 15, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@RKrahl
Copy link
Member

RKrahl commented May 15, 2020

The constructor of icat.ids.DataSelection takes an objs argument that may either be a dict with object ids, another DataSelection or a list of entity objects, see the online documentation. In the latter case, the objects in that list must be either Investigation, Dataset, or Datafile objects.

It might be convenient in some cases to also accept DataCollection in that list of entity objects, with the obvious semantic of adding the related datasets and datafiles to the selection.
@RKrahl RKrahl added the enhancement New feature or request label May 15, 2020
@RKrahl RKrahl added this to the 1.0.0 milestone May 15, 2020
RKrahl added a commit that referenced this issue Jul 13, 2020
@RKrahl
Add tests for Issue #74.
84b642c
@RKrahl RKrahl closed this as completed in e95a756 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@RKrahl