Separate out server-side code for DataGateway #445
Assignees
Comments
|
Hi Brian,
what is the DataGateway? I have obviously missed too many icat meetings!
Andy
Le 12/08/2019 à 11:58, Brian Ritchie a écrit :
…
The DataGateway will want to use Topcat's server side, but not the
browser client.
Though ultimately we may want to pull the code out into a separate
project, perhaps we could create a branch in which the Javascript and
its dependencies are removed?
It seems likely that DataGateway will want to make modifications, but
it may still be useful to be able to merge-in individual changes
between this and the Topcat master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#445?email_source=notifications&email_token=AAI4564PSUTBTEJDSPL2IIDQEEX5PA5CNFSM4IK7UMZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HEVQVHA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI4564Y547B6B3Q5JI5YJTQEEX5PANCNFSM4IK7UMZA>.
|
|
Sorry Andy, it's the name for Topcat's replacement. |
brianritchie1312
added a commit
that referenced
this issue
Aug 12, 2019
See #445. Remove the browser client, and (almost) all references to it in the pom, Travis and Vagrant build configurations. At this point, "mvn clean install" succeeds. An initial Vagrant build failed, but hopefully this has been fixed. The topcat_admin script does not work, as it attempts to retrieve configuration details from topcat.json, which no longer exists.
|
I've added many more tests to the server-side code, mainly for the classes that provide the REST API. I've pulled these into the master, and merged them into the issue#445-server-side-only branch that "fixes" this issue (but should never be pulled into the master!) Note that unless you are using a new Vagrant build, you will have to update the simple authenticator by adding a new user called "nonroot" (with password "nonroot"); this is used by the AdminResource tests as a user without admin rights. |
|
I've added more tests, for FacilityMap and StatusCheck, to issue#445-server-side-only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The DataGateway will want to use Topcat's server side, but not the browser client.
Though ultimately we may want to pull the code out into a separate project, perhaps we could create a branch in which the Javascript and its dependencies are removed?
It seems likely that DataGateway will want to make modifications, but it may still be useful to be able to merge-in individual changes between this and the Topcat master.
The text was updated successfully, but these errors were encountered: