Allow cmake tarball archive to be disabled #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this because you want to use the CMake project in a subdirectory of a larger project, and having a target named "dist" is causing problems? Honestly, since releases are just tagged in git and GitHub does the actual tarballs now, we should probably just remove it. |
madebr
reviewed
Feb 23, 2024
| WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}" | ||
| COMMENT "Building source tarball '${PHYSFS_TARBALL}'..." | ||
| ) | ||
| option(PHYSFS_DISABLE_TARBALL "Disable installing PhysFS tar.gz" OFF) |
There was a problem hiding this comment.
SDL conditionally disables installation, and distribution-related options, when it is built as a subdirectory.
The detection happens here.
Also, I would drop the if(UNIX). If it's up to me, Windows users can also create a distribution. But icculus isn't :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.