Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental support for nested route objects within components #69

Closed
wants to merge 2 commits into from

Conversation

icd2k3
Copy link
Owner

@icd2k3 icd2k3 commented Sep 26, 2022

experimental support for #62

this seems to work... but I'm not super happy with it because, well...
route.element?.type()?.props?.value?.matches[0]?.route?.children[0]?.breadcrumb

A lot of testing will be needed to make sure it doesn't cause any odd side-effects... at the end of the day, this might be a feature request for react-router-dom to provide some kind of way to get the entire route config context.

@icd2k3 icd2k3 added the WIP label Sep 26, 2022
@coveralls
Copy link

coveralls commented Sep 26, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 27b7d4d on component-nested-route-object-support into a51f9e6 on master.

@icd2k3 icd2k3 closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants