Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Type override for BreadcrumbsRouter #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xueyawei
Copy link

@xueyawei xueyawei commented May 9, 2023

Issue: type override cannot use union type, it will not work.

Solution: using Omit to delete original children first then do union type.

@xueyawei xueyawei marked this pull request as ready for review May 9, 2023 02:05
@xueyawei
Copy link
Author

xueyawei commented May 9, 2023

interface A {
a: string,
b: string,
}

type B = A & {
a: number
}

property 'a' in type B will be 'never' type.

@xueyawei xueyawei changed the title FIX: Type override for BreadcrumbsRouter fix: Type override for BreadcrumbsRouter May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant