Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an ArgumentError if given an empty ical string #366

Merged
merged 1 commit into from Jan 13, 2017
Merged

Raise an ArgumentError if given an empty ical string #366

merged 1 commit into from Jan 13, 2017

Conversation

seejohnrun
Copy link
Collaborator

No description provided.

@seejohnrun
Copy link
Collaborator Author

Thanks @dorian
I'm merging this, and merged #368 to address the validation issue in your follow-up comment above.

Would you mind creating issues for remaining parsing errors you've mentioned?

@seejohnrun seejohnrun merged commit e6bceb5 into master Jan 13, 2017
@seejohnrun seejohnrun deleted the empty_ical_invalid branch January 13, 2017 14:38
Chosko pushed a commit to Chosko/ice_cube that referenced this pull request Mar 2, 2017
@Chosko
raise ArgumentError on empty rule_type and rule values (from ice-cube…
14ba416 
…-ruby#366)
@ice-cube-ruby ice-cube-ruby deleted a comment Jul 16, 2019
@ice-cube-ruby ice-cube-ruby deleted a comment Jul 16, 2019
@ice-cube-ruby ice-cube-ruby deleted a comment Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@seejohnrun