Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No SVG icons in 3.3.4 #133

Closed
ghost opened this issue May 8, 2023 · 6 comments
Closed

No SVG icons in 3.3.4 #133

ghost opened this issue May 8, 2023 · 6 comments

Comments

@ghost
Copy link

ghost commented May 8, 2023

I built 3.3.4 on Devuan Chimaera but am unable to see SVG icons as I was with the package in the repositories (which is a much older version, 2.1.2 to be exact).
Here are the configuration options according to icewm --configured:
ao fdomenus fribidi i18n imlib2 librsvg libxpm nls session shape xfreetype2 xinerama xrandr

I have librsvg2 and libimlib2 installed. I read that perhaps gdk-pixbuf is needed, so I tried to build with similar options except using gdk-pixbuf (and I have the libraries for gdk-pixbuf installed including gdk-pixbuf-xlib). SVG icons do not appear in either gdk-pixbuf or imlib2 builds.

@gijsbers
Copy link
Contributor

gijsbers commented May 8, 2023

Now I have icewm configured options: alsa fdomenus fribidi i18n imlib2 librsvg libxpm logevents nls session shape xfreetype2 xinerama xrandr and I do see SVG icons when I open the system menu. Where do you expect to see the SVG icons? You can try nanosvg build option instead of librsvg (it will be automatically downloaded) and also set Trace=icon and observe the output of icewm. If you can't locate the icewm output, you can edit the system icewm-session.desktop and set Exec=/path/to/your/icewm-session -o ~/icewm.output.

gijsbers added a commit to bbidulock/icewm that referenced this issue May 8, 2023
@ghost
Copy link
Author

ghost commented May 8, 2023

Thanks for the suggestion,

You made me realize something. I have IconThemes set to prefer the Oxygen icon set first like so: IconThemes="oxygen:Deepsea:*:-ContrastHigh". I assumed the Oxygen icons were SVG but I was wrong. They are PNG. Following your directions the only output I got from icewm with icewm -o ~/icewm.output were related to xpm's in the theme I'm using: "Warning: Image not readable: /home/hunter/.icewm/themes/bluemetal3/frameITL.xpm".

I rebuilt IceWM with the nanosvg option and tested an SVG icon in the toolbar config. It works fine, so this issue is not a problem with SVG's like I had thought. Sorry.

However, it's strange that the Oxygen icon set no longer takes priority even though the IconThemes variable is set to what I said above. The prefix is /usr/local with other things I've compiled personally, and IconPath is set to "$HOME/.local/share/icons:/usr/share/icons:/usr/share/pixmaps:/usr/local/share/icons:/usr/local/share/pixmaps". The Oxygen icons are named "oxygen" in /usr/share/icons.

@gijsbers
Copy link
Contributor

gijsbers commented May 9, 2023

Then you need to include /usr/share/icons/oxygen in your IconPath. I use something like this :/usr/share/icons/oxygen:/usr/share/icons/Adwaita:/usr/share/icons/hicolor:/usr/share/icons:/usr/share/pixmaps:, etc.

@gijsbers gijsbers closed this as completed May 9, 2023
@ghost
Copy link
Author

ghost commented May 9, 2023

With IconPath="/usr/share/icons/oxygen" I get the same result.

@gijsbers
Copy link
Contributor

gijsbers commented May 9, 2023

Right, I forgot about IconThemes. I think you could start from this:

IconPath="$HOME/.local/share/icons:/usr/share/icons:/usr/share/pixmaps:/usr/local/share/icons:/usr/local/share/pixmaps"
IconThemes="oxygen:Deepsea:*:-ContrastHigh"

The IconThemes seems to be just an include or exclude flag. So it is not about priority. Hence, if you have a star, that includes everything, except what is prefixed by a minus.

@ghost
Copy link
Author

ghost commented May 9, 2023

Thanks, I didn't realize it doesn't pick up a priority.

I was messing around with the IconThemes variable and set it to oxygen:hicolor and this fixed the issue completely. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant