Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IceWM kills non-responding applications in 3 seconds #47

Closed
PetteriAimonen opened this issue Apr 28, 2021 · 3 comments
Closed

IceWM kills non-responding applications in 3 seconds #47

PetteriAimonen opened this issue Apr 28, 2021 · 3 comments

Comments

@PetteriAimonen
Copy link
Contributor

Currently the timeout for _NET_WM_PING is set to 3 seconds:

fPingTimer->setTimer(3000L, this, true);

Sometimes (especially when running out of memory) I have applications that lag for more than 3 seconds, and then icewm just kills them with SIGTERM and they disappear. I would have preferred just to wait a bit more. A timeout of 3 to 5 seconds seems common, but most other WMs show a confirmation dialog before killing the application.

As a quick fix, I think e.g. 60 seconds might be more reasonable default value and maybe this timeout should be made configurable. I can send a pull request for that if the idea sounds ok.

I guess the correct fix would be to show a confirmation dialog, but I'm not familiar enough with icewm internals to know exactly how to implement that.

@gijsbers
Copy link
Contributor

Okay, I will add a ping timeout preference. Thanks for the suggestion.

@PetteriAimonen
Copy link
Contributor Author

I agree that it is not a big problem in general usage, but I've been quite confused by applications just disappearing due to this. Great if you can add a setting :)

gijsbers added a commit to bbidulock/icewm that referenced this issue Apr 29, 2021
@PetteriAimonen
Copy link
Contributor Author

Thanks a lot, I tested the commit and it works great!

(Sorry for not getting back sooner, I must have missed the notification somehow.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants