Missing library link

[ndowens]

[ 12%] Linking CXX executable ../icesh
/usr/bin/ld: /tmp/icesh.kf16zL.ltrans0.ltrans.o: in function IceSh::spy()': <artificial>:(.text+0x1033): undefined reference to walltime()'
collect2: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/icesh.dir/build.make:144: icesh] Error 1
make[1]: *** [CMakeFiles/Makefile2:275: src/CMakeFiles/icesh.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[gijsbers]

Thanks! The cmake build is easy to forget...

[bdubbs]

The cmake fix proposed was insufficient for me. After the fix I get:

Linking CXX executable ../icesh
cd /build/icewm/icewm-1.6.4/build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/icesh.dir/link.txt --verbose=1
/usr/bin/c++ -O3 -DNDEBUG -lXrandr -lXinerama -Wl,--as-needed CMakeFiles/icesh.dir/icesh.cc.o CMakeFiles/icesh.dir/misc.cc.o CMakeFiles/icesh.dir/mstring.cc.o CMakeFiles/icesh.dir/ref.cc.o CMakeFiles/icesh.dir/yarray.cc.o CMakeFiles/icesh.dir/ytimer.cc.o -o ../icesh -L/opt/xorg/lib -lXext -L/opt/xorg/lib -lXrandr -L/opt/xorg/lib -lXinerama -L/opt/xorg/lib -lX11
/usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::~YTimer()': ytimer.cc:(.text+0x234): undefined reference to mainLoop'
/usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::startTimer(long)': ytimer.cc:(.text+0x393): undefined reference to DelayFuzziness'
/usr/bin/ld: ytimer.cc:(.text+0x3b5): undefined reference to mainLoop' /usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::startTimer()':
ytimer.cc:(.text+0x6dd): undefined reference to DelayFuzziness' /usr/bin/ld: ytimer.cc:(.text+0x703): undefined reference to mainLoop'
/usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::fuzzTimer()': ytimer.cc:(.text+0x9cc): undefined reference to DelayFuzziness'
/usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::runTimer()': ytimer.cc:(.text+0xc0e): undefined reference to DelayFuzziness'
/usr/bin/ld: ytimer.cc:(.text+0xc30): undefined reference to mainLoop' /usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::stopTimer()':
ytimer.cc:(.text+0xe50): undefined reference to mainLoop' /usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::enlist(bool)':
ytimer.cc:(.text+0xe80): undefined reference to mainLoop' /usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::disableTimerListener(YTimerListener*)':
ytimer.cc:(.text+0xed0): undefined reference to mainLoop' /usr/bin/ld: CMakeFiles/icesh.dir/ytimer.cc.o: in function YTimer::setTimer(long, YTimerListener*, bool)':
ytimer.cc:(.text+0xf13): undefined reference to `mainLoop'
collect2: error: ld returned 1 exit status

[ndowens]

That is weird, as it built fine after I did this for Voidlinux.

[bdubbs]

I'll note that it builds fine with autotools.

[ndowens]

Are you building manually or through a package manager

[bdubbs]

I am using the instructions at
http://www.linuxfromscratch.org/blfs/view/svn/x/icewm.html
but with git master.

None of the defines should make any difference for internal references.

[ndowens]

https://github.com/void-linux/void-packages/blob/dc4562ceb0ad8b67f9e2bba49b5c84cb31874784/srcpkgs/icewm/template is how our build is ran. Try with -DENABLE_LTO=ON and CXXFLAGS="-Wno-odr -fno-strict-aliasing" is probably the most important of the template

[bdubbs]

I tried with a couple of variations. It looks like -DENABLE_LTO=ON is the option that fixes the problem.

[ndowens]

May submit a PR to use that as default

…

On Thu, Jan 9, 2020 at 1:58 PM bdubbs ***@***.***> wrote: I tried with a couple of variations. It looks like -DENABLE_LTO=ON is the option that fixes the problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AAA4X34A5XL5YHTVV3PSDWLQ456YFA5CNFSM4KEDFEQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIRSSXI#issuecomment-572729693>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4X352KU6FFDODQLW4PYLQ456YFANCNFSM4KEDFEQQ> .