Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdo, fixed sql error if emtpy filter #249

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Pdo, fixed sql error if emtpy filter #249

merged 2 commits into from
Dec 3, 2018

Conversation

Yahasana
Copy link
Contributor

@Yahasana Yahasana commented Dec 1, 2018

No description provided.

@mruz
Copy link
Member

mruz commented Dec 1, 2018

How about if you pass NULL as filters? It should be WHERE TRUE.

@Yahasana
Copy link
Contributor Author

Yahasana commented Dec 2, 2018

how about filters = []

@mruz mruz merged commit 6a9975a into ice:dev Dec 3, 2018
@Yahasana Yahasana mentioned this pull request Dec 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruz mruz mruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yahasana @mruz