Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support default and optional in tuples and arrays #226

Merged
merged 2 commits into from
Mar 26, 2021
Merged

support default and optional in tuples and arrays #226

merged 2 commits into from
Mar 26, 2021

Conversation

eyalpost
Copy link
Contributor

Resolves #175
Solution: Set "value" variable to the item being validated. Similar to how properties are validated in object.js

@erfanium erfanium self-requested a review March 20, 2021 21:08
erfanium
erfanium approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@erfanium erfanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great👍

@erfanium erfanium requested a review from icebob March 23, 2021 14:08
icebob
icebob requested changes Mar 26, 2021
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add the these tests to the integration.spec.js, as well.

@eyalpost
Copy link
Contributor Author

LGTM, but please add the these tests to the integration.spec.js, as well.

@icebob Done

icebob
icebob approved these changes Mar 26, 2021
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@icebob icebob merged commit c0990d2 into icebob:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

@erfanium erfanium erfanium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tuple item dosent support default and optioanl
3 participants
@eyalpost @icebob @erfanium