Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor index.d.ts and ts tests #251

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Refactor index.d.ts and ts tests #251

merged 1 commit into from
Jul 10, 2021

Conversation

erfanium
Copy link
Collaborator

@erfanium erfanium commented Jul 8, 2021

fixes #171

@erfanium erfanium requested a review from icebob July 8, 2021 14:12
icebob
icebob reviewed Jul 9, 2021
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge whether it is good or not. Can it cause a breaking issue for TS users?

@erfanium
Copy link
Collaborator Author

As tests are working, it should work. Also fixes typescript problem with Deno.

@icebob icebob merged commit a159be2 into master Jul 10, 2021
@icebob icebob deleted the fix-deno-ts branch July 10, 2021 07:08
@icebob
Copy link
Owner

icebob commented Jul 14, 2021

Why I get a lot of ts errors when I run npm test locally?
image

@icebob
Copy link
Owner

icebob commented Jul 14, 2021

It works after a npm run build. Why TS unit tests use the d.ts file from the dist?

@erfanium
Copy link
Collaborator Author

Screenshot from 2021-07-14 22-31-53
It works for me, without npm run build, with node v16.2.0
If you have installed ts-node, or typescript globally, remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno + TS => Doesn't work
2 participants
@erfanium @icebob