Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix record rule #308

Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix record rule #308

merged 1 commit into from
Aug 29, 2022

Conversation

hugebdu
Copy link
Contributor

@hugebdu hugebdu commented Aug 29, 2022

fixes #307

@hugebdu
Copy link
Contributor Author

hugebdu commented Aug 29, 2022 •
edited

@FFKL please review 🇺🇦

icebob
icebob approved these changes Aug 29, 2022
View reviewed changes
Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@icebob icebob merged commit e273136 into icebob:master Aug 29, 2022
@FFKL
Copy link
Contributor

FFKL commented Aug 29, 2022

@icebob @hugebdu Cool! I was about to look at the issue but it's already done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in record rule?
3 participants
@hugebdu @FFKL @icebob