discr sys fits/service mods, bugfixes, docstrings, code formatting, remove proprietary code #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* binning.py: is_bin_spacing_log check using allclose for FP32 compat * fit_discrete_sys_nd.py: cleanups * format.py: binary prefixes explicitly only for values >= 0 * setup.py: add fit_discrete_sys_nd.py as pisa-fit_discrete_sys_nd on install
…n; misc fixups, black formatting
…s to in-mem pipeline config(s)
…g paths and texts); do as much stuff as possible to get to errors faster if they exist
* add documentation of fit json file format in pi_hyperplanes (TODO: also document in fit_discrete_sys_nd.py) * add units to fit config, pi_hyperplanes (doesn't break w/o though, just assumes dimensionless) * for now, all pi_hyperplanes binning checks are disabled (TODO: enable but check at FP32 precision!)
jllanfranchi
changed the title
…small_fixups_allow3dlookup
…erywhere (strip() accepted solution); tested
…, test that fit works
…ookup Merge small fixups allow3dlookup
…unctions Removing proprietary flux functions
jllanfranchi
changed the title
|
Merging as squash merge so we can back changes out if there are issues that arise. |
jllanfranchi
added a commit
that referenced
this pull request
Feb 13, 2019
…emove proprietary code (#514) * core/binning.py * `is_bin_spacing_log` check always using `allclose` for FP32 compatibility * core/base_stage.py * black formatting only * core/pi_stage.py * add some method docstrings (not all added / totally useful, but should be better now) * PISA and black formatting * core/pipeline.py * fix regression which removed raising AttributeError when `__getattr__` is called with non-existent stage / non-existent attr * black formatting * core/stage.py * black formatting * utils/format.py * binary prefixes explicitly fail if values < 0 * setup.py * add `fit_discrete_sys_nd.py` as `pisa-fit_discrete_sys_nd` as a script installed by PISA * stages/data/icc.py * icc params documented with actual params used * stages/xsec/genie_sys.py * docstring fixups * black formatting * stages/discr_sys/pi_hyperplanes.py * fixup, augment docstrings * fit_cfg able to modify specified pipeline config incl. an apply_to_all_sets section * fix logging outputs for modifications to in-mem pipeline config(s) * do as much stuff as possible to get to errors faster if they exist * add units handling for interpreting values of hyperplane fit params * **TODO** for now, all pi_hyperplanes binning checks are disabled (TODO: enable but check at FP32 precision!) * misc fixups * black formatting * scripts/fit_discr_sys_nd.py * add units handling for hyperplane fit params * record more info to fit json file (binning (at top level), fit cfg path and text, pipeline cfg paths and texts, hyperplane fit param units) * allow modifying pipeline configs specified in fit configs * document the discrete fit config file format, "features" (units, modifying a pipeline config) at the top of the script * code cleanups * black formatting * pi_simple * Remove proprietary code but can use that code from fridge (error message added to inform user of the path needed in PISA_RESOURCES if the code cannot be found) * Black formatting, pylint ignores added where appropriate * pylintrc * add C0330 as per psf/black#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_bin_spacing_logcheck always usingallclosefor FP32 compatibility__getattr__is called with non-existent stage / non-existent attrfit_discrete_sys_nd.pyaspisa-fit_discrete_sys_ndas a script installed by PISA