Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why hardcode the URL of ggez to a specific version? #13

Closed
mlindner opened this issue Sep 9, 2019 · 1 comment
Closed

Why hardcode the URL of ggez to a specific version? #13

mlindner opened this issue Sep 9, 2019 · 1 comment
Labels
improvement An internal improvement question Further information is requested
Milestone
0.1.0

Comments

@mlindner
Copy link

mlindner commented Sep 9, 2019 •
edited

https://github.com/hecrj/iced/blob/e6f9b5a16e0b529c4d4cacd6d07e47577403ae39/Cargo.toml#L28

Why is the specific URL hardcoded instead of using the mainline 0.5.1 release?
@hecrj
Copy link
Member

hecrj commented Sep 10, 2019 •
edited

It's explained in the examples README: https://github.com/hecrj/iced/tree/master/examples#tour

Basically, I fixed issues on HiDPI displays and added a type to efficiently cache text measurements.

But now that you bring it up, we should probably add a comment in the Cargo.toml file.

@hecrj hecrj added question Further information is requested improvement An internal improvement labels Sep 10, 2019
@hecrj hecrj closed this as completed in 2913c64 Sep 10, 2019
@hecrj hecrj added this to the 0.1.0 milestone Sep 24, 2019
ids1024 pushed a commit to ids1024/iced that referenced this issue Dec 23, 2022
@wash2
Merge pull request iced-rs#13 from pop-os/feat/output_events
1d7fcb7 
feat: sent output events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement An internal improvement question Further information is requested
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@hecrj @mlindner