More pane grid fixes #1480
Merged
More pane grid fixes #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `grabbing` interaction while dragging - Ignore grab interaction when dragging is disabled
derezzedex
approved these changes
Oct 17, 2022
bungoboingo
approved these changes
Oct 18, 2022
hecrj
requested changes
Oct 19, 2022
hecrj
added
bug
Wait! Don't merge, I didn't test and I think I found a bug :P Edit: Ok, it's fixed in 069371c, I was accidentally using the parent layout for the pane render |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderer.with_layer, it's possible for their content to be drawn on top of the picked / dragging pane if the pane is iterated after the picked pane. This ensures picked pane is always rendered last and will therefore always come on top.