Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @interpolate(flat) attribute as per the WebGPU spec #2071

Merged
merged 2 commits into from Sep 7, 2023

Conversation

Davidster
Copy link
Contributor

I wasn't able to get iced working with webgpu without this

User-defined vertex outputs and fragment inputs of scalar or vector integer type must always be specified as @interpolate(flat)

https://www.w3.org/TR/WGSL/#interpolation

User-defined vertex outputs and fragment inputs of scalar or vector integer type must always be specified as @interpolate(flat)

https://www.w3.org/TR/WGSL/#interpolation
@Davidster Davidster changed the title use @interpolate(flat) attribute as per the WebGPU spec: use @interpolate(flat) attribute as per the WebGPU spec Sep 4, 2023
@hecrj hecrj added bug Something isn't working rendering wgpu fix labels Sep 7, 2023
@hecrj hecrj added this to the 0.12.0 milestone Sep 7, 2023
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@location(3) @interpolate(flat) colors_3: vec4<u32>,
@location(4) @interpolate(flat) colors_4: vec4<u32>,
@location(5) @interpolate(flat) offsets: vec4<u32>,
@location(6) @interpolate(flat) direction: vec4<f32>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't an integer type. I imagine we can revert it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah that was unintentional

@hecrj hecrj enabled auto-merge September 7, 2023 03:43
@hecrj hecrj merged commit d82c8b5 into iced-rs:master Sep 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix rendering wgpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants