Fix(infinite list): move visible elements when an update occurs offscreen before them #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When there is a `Change::Update` on an element that isn't visible it wasn't moving the layouts, however when that element is before the ones visible they need to be moved or else they will be on the wrong position if there was a height change. - TODO: maybe all this layout moving and offset calculation logic should only be run if `height_difference` was different than 0. Since when it is 0 it changes nothing. Sometimes this update changes are only value updates that don't change the height, so there is no point in doing it.
alex-ds13
force-pushed
the
feature/list-widget-reloaded
branch
from
478c41f
to
f683067
Compare
alex-ds13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to a bug on the branch
feature/list-widget-reloaded:Change::Updateon an element that isn't visible it wasn't moving the layouts, however when that element is before the ones visible they need to be moved or else they will be on the wrong position if there was a height change.height_differencewas different than 0. Since when it is 0 it changes nothing. Sometimes this update changes are only value updates that don't change the height, so there is no point in doing it in those cases.I was going to tell you about this on Discord but since you weren't online I thought there was no harm in doing this PR anyway since I had already made the fix and tried it. Feel free to make your own fix if you prefer.