Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating empty Mesh2D in canvas::Frame #278

Merged
merged 1 commit into from Apr 9, 2020
Merged

Stop generating empty Mesh2D in canvas::Frame #278

merged 1 commit into from Apr 9, 2020

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Apr 9, 2020

This PR stops producing an empty Primitive::Mesh2D in Frame::into_primitive when nothing is tessellated by lyon. This could lead to crashes in some graphics drivers.

@hecrj hecrj added the bug Something isn't working label Apr 9, 2020
@hecrj hecrj added this to the 0.1.1 milestone Apr 9, 2020
@hecrj hecrj self-assigned this Apr 9, 2020
@hecrj hecrj merged commit 867dad6 into master Apr 9, 2020
@hecrj hecrj deleted the fix/canvas-empty-mesh branch April 9, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hecrj