Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce and handle CursorEntered and CursorLeft #289

Merged
merged 2 commits into from Apr 13, 2020
Merged

Produce and handle CursorEntered and CursorLeft #289

merged 2 commits into from Apr 13, 2020

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Apr 11, 2020

Fixes #287.

@hecrj
Produce cursor events in iced_winit::conversion
4b0cc17
@hecrj
Make cursor unavailable on leave in iced_winit
f652e84 
For now, we just set the cursor position to some negative coordinates.
This is a temporary hack until we are able to encode cursor
availability. Layers and/or multi-window support will make this
apparent.
@hecrj hecrj added the bug Something isn't working label Apr 11, 2020
@hecrj hecrj added this to the 0.1.1 milestone Apr 11, 2020
@hecrj hecrj self-assigned this Apr 11, 2020
@hecrj hecrj mentioned this pull request Apr 11, 2020
Closed
@hecrj hecrj merged commit bc70ba1 into master Apr 13, 2020
@hecrj hecrj deleted the fix/cursor-events branch April 13, 2020 02:33
hecrj added a commit that referenced this pull request Apr 17, 2020
@hecrj
Revert "Merge pull request #289 from hecrj/fix/cursor-events"
ae546a5 
`winit` seems to produce `CursorEntered` and `CursorLeft` events after
wheel scrolling for no apparent reason (?). This causes annoying flickering when hovering some widgets on a scrollable.

I should investigate this further. We are rolling back the fix for the
time being.
hecrj added a commit that referenced this pull request Apr 26, 2020
@hecrj
Revert "Merge pull request #289 from hecrj/fix/cursor-events"
4ce7357 
`winit` seems to produce `CursorEntered` and `CursorLeft` events after
wheel scrolling for no apparent reason (?). This causes annoying flickering when hovering some widgets on a scrollable.

I should investigate this further. We are rolling back the fix for the
time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.

iced_native::input::mouse::Event::CursorLeft not emitted when the cursor leaves the window
1 participant
@hecrj