Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated Fill comment for Column and Row #545

Merged
merged 3 commits into from Oct 17, 2020
Merged

Remove outdated Fill comment for Column and Row #545

merged 3 commits into from Oct 17, 2020

Conversation

MonliH
Copy link
Contributor

@MonliH MonliH commented Oct 1, 2020

This PR makes the default width Length::Fill for the column widget.
Fixes #544.

@hecrj
Copy link
Member

hecrj commented Oct 3, 2020

Hey, thanks!

I changed the behavior from Fill to Shrink in #139, but I forgot to update the documentation 😅 We should fix that instead!

@MonliH
Copy link
Contributor Author

MonliH commented Oct 3, 2020

Oh, awesome! I'll document it then 😄.

@MonliH
Copy link
Contributor Author

MonliH commented Oct 3, 2020

I've documented this behaviour in the Column and Row widget, please let me know if I missed any other widgets that are out of date.

hecrj
hecrj reviewed Oct 8, 2020
View reviewed changes
native/src/widget/column.rs Outdated Show resolved Hide resolved
@MonliH MonliH changed the title Make column fill container - satify documented behaviour Document widget fill behaviour Oct 8, 2020
@MonliH MonliH changed the title Document widget fill behaviour Document the widget fill behaviour Oct 8, 2020
@hecrj hecrj added the improvement An internal improvement label Oct 17, 2020
@hecrj hecrj added this to the 0.2.0 milestone Oct 17, 2020
@hecrj hecrj changed the title Document the widget fill behaviour Remove outdated Fill comment for Column and Row Oct 17, 2020
hecrj
hecrj approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🎉

@hecrj hecrj merged commit 23647d2 into iced-rs:master Oct 17, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Column.width = Shrink by default
2 participants
@MonliH @hecrj