Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Scrollbar Width #575

Merged
merged 6 commits into from Oct 27, 2020
Merged

Custom Scrollbar Width #575

merged 6 commits into from Oct 27, 2020

Conversation

clarkmoody
Copy link
Contributor

Updates Scrollable, adding facilities for updating the width of the scrollbar and scroller independently. We also gain control of the margin around the scrollbar.

Adds an example showing various ways these values interact.

Screen Shot 2020-10-22 at 4 14 37 PM

@clarkmoody clarkmoody changed the title Scrollable width Custom Scrollbar Width Oct 22, 2020
@hecrj hecrj added the feature New feature or request label Oct 23, 2020
@hecrj hecrj added this to the 0.2.0 milestone Oct 23, 2020
- Rename `Config` to `Variant`
- Include `State` in `Variant` to avoid `zip`
- Break long string literal
- Split `style` module into its own file
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 🎉

I made some minor improvements to the code of the example and changed the dark theme to make it more consistent with the styling example and reduce its contrast:

image

If you agree with the changes, I believe we can merge this!

@clarkmoody
Copy link
Contributor Author

RIP my beautiful color scheme 😞

Latest version looks good to me! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants