Allow any param #11
Merged
Allow any param #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caub looks good, can you fix conflicts, and I'll get it merged |
caub
commented
Jul 1, 2017
test/parse.js
Outdated
|
|
||
| // test('return last value of repeated parameter', function(t){ |
There was a problem hiding this comment.
@monteslu is it really necessary this test and behavior?
I think it's more confusing, and also I'd prefer to use URL and URL#searchParams#get (but it takes first value not last)
|
Why just max? All config parameters should work, eg ssl |
|
Renamed, this PR allows anything var result = url.parse(......., true);
var config = Object.assign(result.query, opts); |
|
@monteslu Is the PR ok? or I close it? it's like the master branch, just more simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set max param for a pool, from querystring